Manage black version using requirement file - #207
Merged
Conversation
aahung
force-pushed
the
better-black
branch
4 times, most recently
from
October 28, 2020 21:39
7eec9cb to
210b252
Compare
aahung
marked this pull request as ready for review
October 28, 2020 21:39
hoffa
previously approved these changes
Oct 28, 2020
hawflau
reviewed
Oct 28, 2020
| # Validate Code was formatted with Black | ||
| - "/tmp/black --check setup.py tests aws_lambda_builders" | ||
| # Validate Code was formatted with Black, black is only supported in Python 3 | ||
| - if [[ $PYTHON_VERSION != "2"* ]]; then black --check setup.py tests aws_lambda_builders; fi |
Contributor
There was a problem hiding this comment.
is there any reason that you use $PYTHON_VERSION != "2"* but not $PYTHON_VERSION == "3"* or $PYTHON_VERSION -gt "2"*?
Contributor
Author
There was a problem hiding this comment.
Changed to if [[ $PYTHON_VERSION > "3" ]]; then black --check setup.py tests aws_lambda_builders; fi
There was a problem hiding this comment.
This might be pedantry, but the > operator compares lexicographically; is that the intention?
Contributor
Author
There was a problem hiding this comment.
either lexicographically or numerically should be able to specify "python 3 or higher" right?
hawflau
previously approved these changes
Oct 28, 2020
Contributor
Author
|
As discussed with @hoffa offline, with
|
hawflau
approved these changes
Oct 28, 2020
hoffa
approved these changes
Oct 28, 2020
mndeveci
added a commit
that referenced
this pull request
Jan 12, 2021
* Added Dynamic Encoding Selection Based on Windows System Default * Fixed dotnet output system dependent encoding * Updated test_custom_make urllib3 Version * Reformatted with black * Rollback Changes to popen for Python 2 Support * Added Doc Page for DotNet Output Encoding * fix(ruby): use stdout stream to raise exceptions from bundler - relevant error information is in stdout instead of stderr for bundler. * chore: bump version to 1.1.0 * chore: Upgrade pytest to 6.1.1 * chore: Upgrade mock to 4.0.2 * chore: Upgrade parameterize to 0.7.4 * chore: Upgrade coverage to 5.3 * chore: Upgrade flake8 to 3.8.4 * chore: Upgrade pylint to 2.6.0 * Consider using Python 3 style super() without arguments (super-with-arguments) * Implicit string concatenation found in assignment (implicit-str-concat) * Consider explicitly re-raising using the 'from' keyword (raise-missing-from) * Only install backports.tempfile for 2.7 & 3.6 * python 2 fallbacks (pylint & mock) * Revert "Consider using Python 3 style super() without arguments (super-with-arguments)" This reverts commit 44284ea. * Revert "Consider explicitly re-raising using the 'from' keyword (raise-missing-from)" This reverts commit cd7c16e. * Disable rules that affecting Python 2 * Manage black version using requirement file (#207) * chore: Manage black version in dev.txt * chore: Update appveyor, use black in pip * chore: Add pre-commit-config * chore: Format with black 20.8b1 * chore: Add make pr2.7 for Python 2 that does not run black * chore: Remove python patch version in AppVeyor to be more robust (#213) * chore: Remove biased language (#212) * fix: run GlobalToolInstallAction in a lock block and only once (#214) * fix: run GlobalToolInstallAction in a lock block and only once * chore: change field name and update unit tests * chore: black formatting * fix: change tests to use threadpool for py2 * chore: update assert call and change usage of Executor * chore: bump version to 1.2.0 (#218) Co-authored-by: Wilton Wang <CoshUS@users.noreply.github.com> Co-authored-by: Sriram Madapusi Vasudevan <3770774+sriram-mv@users.noreply.github.com> Co-authored-by: Sriram Madapusi Vasudevan <srirammv@amazon.com> Co-authored-by: Sam Liu <xinhol@amazon.com> Co-authored-by: _sam <3804518+aahung@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Manage black in dev.txt, almost the same as aws/serverless-application-model#1748
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.